Update/fix remaining opcache zend_func_info.c signatures #4967
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See UPGRADING: > . The GD extension now uses objects as the underlying data structure for > images, rather than resources. These objects are completely opaque, i.e. > they don't have any methods. Remove types which are no longer in Reflection due to throwing instead of emitting warnings. Remove entries where reference counts are 0 and types are duplicated.
|
The build failure for ext/mysqli/tests/bug55283.phpt seems to be pre-existing. 4962 seems unrelated to anything used by mysqli, so it could be a travis issue. https://travis-ci.org/php/php-src/builds?utm_medium=notification&utm_source=github_status |
nikic
approved these changes
Dec 5, 2019
|
It's unfortunate that there's still so much duplicated info between stubs and opcache... For the most part it's just the rc1 information, I wonder if we should maybe separate that out from the type information, so we don't have to duplicate the latter. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See UPGRADING:
Remove types which are no longer in Reflection due to throwing instead of
emitting warnings.
Remove entries where reference counts are 0 and types are duplicated.